Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12_5_X] Bug fix in EMTF GEM and RPC unpacker blocks #39461

Merged
merged 1 commit into from
Sep 21, 2022
Merged

[12_5_X] Bug fix in EMTF GEM and RPC unpacker blocks #39461

merged 1 commit into from
Sep 21, 2022

Conversation

eyigitba
Copy link
Contributor

@eyigitba eyigitba commented Sep 20, 2022 •
edited
Loading

PR description:

This is the backport of #39460

This PR fixes a bug that was mentioned in #39456

The bug was introduced in #39390

It was a stupid mistake on my part that somehow went in. The index for the for loop does not match the if/else statements, hence causing an empty GEM/RPC TP to be created which then causes the crash when we try to create detID.

This should be backported to 12_4_X and 12_5_X to fix the same ug in those releases.

PR validation:

Tested with running the unpacker on the data files mentioned in #39456. Unpacker runs and assigns the correct values to GEM/RPC TPs.

File used: /eos/cms/store/t0streamer/Data/Express/000/359/045/run359045_ls0144_streamExpress_StorageManager.dat

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the backport of #39460

@eyigitba
Copy link
Contributor Author

type bugfix

@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Sep 20, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 20, 2022 •
edited
Loading

A new Pull Request was created by @eyigitba for CMSSW_12_5_X.

It involves the following packages:

  • EventFilter/L1TRawToDigi (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@perrotta
Copy link
Contributor

backport of #39460

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta perrotta mentioned this pull request Sep 20, 2022
Closed
@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3666f/27692/summary.html
COMMIT: 042ca77
CMSSW: CMSSW_12_5_X_2022-09-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39461/27692/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 250202.172250202.172_TTbar_13UP17+TTbar_13UP17INPUT+DIGIPRMXUP17_PU25_RD+RECOPRMXUP17_PU25+HARVESTUP17_PU25/step2_TTbar_13UP17+TTbar_13UP17INPUT+DIGIPRMXUP17_PU25_RD+RECOPRMXUP17_PU25+HARVESTUP17_PU25.log
  • 250206.17250206.17_ZMM_13UP17+ZMM_13UP17INPUT+DIGIPRMXUP17_PU25+RECOPRMXUP17_PU25+HARVESTUP17_PU25/step2_ZMM_13UP17+ZMM_13UP17INPUT+DIGIPRMXUP17_PU25+RECOPRMXUP17_PU25+HARVESTUP17_PU25.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3699454
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3699424
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

@cmsbuild please test

  • the failure comes from errors in opening input files

@perrotta
Copy link
Contributor

@francescobrivio as you noticed, the "file opening" errors in tne input relvals are clearly unrelated from this PR: there was no reason to restart the tests for them. I'll keep the previous results for good and I'll merge this one right now.

@francescobrivio
Copy link
Contributor

@francescobrivio as you noticed, the "file opening" errors in tne input relvals are clearly unrelated from this PR: there was no reason to restart the tests for them. I'll keep the previous results for good and I'll merge this one right now.

Of course! You are the release manager 😄

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 1275c74 into cms-sw:CMSSW_12_5_X Sep 21, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3666f/27703/summary.html
COMMIT: 042ca77
CMSSW: CMSSW_12_5_X_2022-09-20-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39461/27703/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3699454
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3699424
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok bug-fix fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_5_X
Development

Successfully merging this pull request may close these issues.
5 participants
@eyigitba @cmsbuild @perrotta @cecilecaillol @francescobrivio